This repository has been archived by the owner on Aug 1, 2020. It is now read-only.
more CPR logic improvements #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are actually relatively rare if your receiver is good. If the first global CPR for an aircraft gives a bogus position, make sure a contradicting global CPR will stop aircraft relative CPR decoding.
Using combine_validity which uses the older cpr_valid.update time to determine the position_valid.update time is wrong, as the update time of the position is the reception time of the current CPR. The position_valid.update time is also used for the speed check which relies on the actual time of the position.
|
Would you prefer pull requests against the dev branch or the master branch? |
|
dev branch is preferred since it gets combined with all other changes and then on release goes into master. |
|
I might have some more CPR stuff which kinda goes on top of what i already submitted. Maybe i should just make a PR for dev with the commits i already did and then the new stuff on top. Anyway i'm doing some local testing before i will make another PR :) |
|
Merging shouldn't be a problem. I can solve conflicts manually in any case. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this should be a good model for dealing with bad CPRs.
Also make the speed check more reliable by using the correct position_valid.update time when doing global CPR.
And add some stats that were never fully implemented.