This repository has been archived by the owner on Aug 1, 2020. It is now read-only.
Some improvements for position updating / CPR handling #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we have ADS-B CPRs and get a MLAT synthetic CPR, don't call updatePosition as this messes up the position state.
If we receive a new CPR and the old CPR is the one with bad data, we will throw the data away again. But if we are lucky and receive the CPR that was bad, we get a good position again faster. Also this makes the speed check impossible on the next decode, which is bad. Instead move the position validity closer to expiration. That should help with wrongly accepting a bad position and failing all speed checks afterwards.
|
Just as an FYI, the second patch is somewhat questionable. I'm working on a better solution. |
|
Go ahead. And thanks for contributing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found this bug in dump1090-fa and suspected you still had the same code.
This in particular improves the situation when aircraft are on the ground at an airport and you are getting MLAT positions for them as well.
Getting an MLAT position while having a good ADS-B position could before these fixes completely invalidate the position, also an MLAT position could be in the json without being marked as such.