Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of another requirement for cluster configuration on RHEL8 #122751

Closed
wants to merge 1 commit into from

Conversation

rubenlopesms
Copy link
Contributor

No description provided.

Copy link
Contributor

@rubenlopesms : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 95acb3b:

✅ Validation status: passed

File Status Preview URL Details
articles/sap/workloads/high-availability-guide-rhel-pacemaker.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ShannonLeavitt
Copy link
Contributor

@rdeltcheva

IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label May 23, 2024
Copy link
Contributor

@rdeltcheva rdeltcheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed command change is dropping the totem token parameter - that is really important part of the command. If ommited, it will lead to cluster instability. Also, the command is in the section applicableto both RHEL8 and RHEL9, not only RHEL 8. Could you please let me know what is prompting this requested change?

Copy link
Contributor

@rdeltcheva rdeltcheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command should not drop the token.

@denrea
Copy link
Contributor

denrea commented Jul 5, 2024

@rubenlopesms @rdeltcheva

Can you review this old PR and determine whether it needs to be closed or merged?

@MicrosoftDocs/public-repo-pr-review-team

@ShannonLeavitt
Copy link
Contributor

@rubenlopesms - Could you respond to the comment from @rdeltcheva? If we don't hear from you, we will need to close this PR.

@rubenlopesms
Copy link
Contributor Author

Hello @ShannonLeavitt @rdeltcheva Sorry, I was on vacations. I was doing some lab tests for a Training and I saw that the command didn't worked as explained. So, it's why I decided to request the change.

@Court72
Copy link
Contributor

Court72 commented Aug 29, 2024

I sent an email to the content owner today.

@Court72
Copy link
Contributor

Court72 commented Aug 30, 2024

The content owner responded:

"We cannot drop the token in the command. It is necessary so that the cluster can survive platform maintenance events.  So please close this PR."

@Court72 Court72 closed this Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants