Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Microsoft Bond Serialization Support to CacheManager #83

Closed
wants to merge 1 commit into from
Closed

Adding Microsoft Bond Serialization Support to CacheManager #83

wants to merge 1 commit into from

Conversation

loneshark99
Copy link

Hello,

I have added Microsoft Bond Serialization Support in the CacheManager project. Would really appreciate if you can take a look. You can get more information about Microsoft Bond here https://github.com/Microsoft/bond . I think it will be useful to support this Serialization Format in Cache Manager.

Thanks.

@MichaCo
Copy link
Owner

MichaCo commented Aug 19, 2016

@loneshark99 sure why not. Could you please also add some unit tests for that?

There are sets of tests already per serialization implementation here.
Those should be pretty easy to adopt for your implementation.

"dependencies": {
"Bond.CSharp": "4.2.1",
"CacheManager.Core": "0.9.0-*",
"NETStandard.Library": "1.6.0"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not add the NETStandard.Library to global dependencies. This would install all the mess if you have a normal .net45x project for example.

@loneshark99
Copy link
Author

@MichaCo I running into some issue with the different .Net versions when I add the Bond Nuget Package. Trying to figure out those build issues. Seems like its only supported in .Net 4, 4.5 but when I build its trying to build for .net Standard.

@MichaCo
Copy link
Owner

MichaCo commented Aug 25, 2016

@loneshark99 If Bond doesn't support .NET Core yet (and according to nuget.org, that's the case), you cannot target netstandard1.x and just have to remove that.

@MichaCo
Copy link
Owner

MichaCo commented Feb 7, 2017

@loneshark99 It's been some time, sorry for the pretty late response to this and thanks again for your effort.

After reviewing your PR and playing a little bit with Bond, I found that there is a lot more stuff needed to make it work and I started over from scratch.
see d4b88b6

Just an example, not all clr types are supported out of the box, like DateTime or TimeSpan, which are used in CacheItem and would actually cause exceptions if not taken care of.
There are many other things to improve performance, like reusing the writers per schema and pooling buffers... So, I did all that and it really is a great thing. It is actually even faster than the protobuf version ^^

Closing the PR.

@MichaCo MichaCo closed this Feb 7, 2017
@MichaCo MichaCo mentioned this pull request Feb 7, 2017
10 tasks
@loneshark99
Copy link
Author

@MichaCo Cool. Sorry I lost track with other things happening. Thanks, Yash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants