Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#55 Add a Compressed Json Serializer using the GZipStream #56

Merged
merged 2 commits into from
Jun 5, 2016

Conversation

fgideali
Copy link
Contributor

@fgideali fgideali commented Apr 4, 2016

PR for #55

"dnx451": { },
"dnx451": {
"dependencies": {
"System.IO.Compression": "4.1.0-beta-23516"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for dnx451 and net45, you should not add .net core assemblies. Either the Compression stuff is already available, or you add them to frameworkAssemblies.

@MichaCo
Copy link
Owner

MichaCo commented Apr 4, 2016

Thanks for the PR @fgideali, looks very good overall :)
Don't worry about the 2nd check which is failing, I'll take care of all that after a merge.

Could you take a look at the project.json references? I think it is wrong how it is setup right now.
And targeting .net core should work, too, I think

@fgideali
Copy link
Contributor Author

fgideali commented Apr 7, 2016

Indeed, the System.IO.Compression dependency is only needed for the .net core
I fixed the project references.

Is there anything else I could do to prevent that fail on AppVeyor?

@MichaCo
Copy link
Owner

MichaCo commented Apr 7, 2016

Thanks!
For the 2nd solution to build, the file needs to be added as reference to the old csproj.
But don't worry, I'll go through that when I merge the changes and create a new release.
Hopefully I find some time this weekend... ;)

@MichaCo MichaCo merged commit 42606be into MichaCo:dev Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants