Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated StackExchange.Redis library version #337

Closed

Conversation

borgmatthew
Copy link

No description provided.

@MichaCo
Copy link
Owner

MichaCo commented May 5, 2021

Hi @borgmatthew ,
thanks for the PR

Why did you make the changes in RedisValueConverter?

@borgmatthew
Copy link
Author

@MichaCo the changes in RedisValueConverter were required for the project to compile. Casting was required as the references were ambiguous. I am attempting to update to the latest Redis client version, which is 2.2.4.

@borgmatthew
Copy link
Author

@MichaCo Updated to the latest version of the StackExchange.Redis library

@MichaCo
Copy link
Owner

MichaCo commented May 31, 2021

Could you undo the icon thing and any changes to the test project?
<PackageReference Include="System.Runtime.CompilerServices.Unsafe" Version="5.0.0" />

I actually just did similar changes, but I can merge your. Just for those 2 thing I got more/different updates.
I also just did the update to the latest redis version, didn't remember that there was a PR ^^
But I'd merge your changes then anyways

@borgmatthew
Copy link
Author

@MichaCo No worries, this can be closed then. Please note that there is a newer version of StackExchange.Redis, which is version 2.2.62

@MichaCo
Copy link
Owner

MichaCo commented Jul 2, 2021

ok

@MichaCo MichaCo closed this Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants