Added DataContract serialization support via System.Runtime.Serialization library. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 10, 2017 18:13
|
hey @rebulanyum thanks for the PR! I'll take a look soon™ ;) |
|
@MichaCo don't have free time for merging, right? 😄 |
|
@rebulanyum thanks again for the great PR. I will go ahead and do some code style changes and integrate it with some other things. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed to store entities of Microsoft Dynamics 365 which are only serialized correctly by DataContract serializers. So, I've added DataContract serialization support via System.Runtime.Serialization library.
I tried but then gave up trying to support .NetStandard1.6 and below versions because of this issue. So I'm just supporting .NetFramework4.5 & .NetStandard2.0 right now.
One more thing: DataContractJsonSerializer class may serialize DateTime values in a different way. I've added comment to let the user know the usage on CacheManager.Tests project.