[WIP]Add support for ClearRegion for memcached #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themakshter
changed the title
MichaCo
added a commit
that referenced
this pull request
Feb 11, 2017
…#104. Fixed custom transcoder to not care about non-object things. Unix timestamp impl with benchmarks, for fun...
|
@themakshter hey, I finally had some time to look into this. I first didn't really liked the implementation as it leaves existing keys still in the cache and they might never be removed ^^ I had to implement the solution slightly more complex than your approach and decided to do it from scratch instead of merging your PR, sorry about that. But thanks for pushing the idea 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extremely crude solution at the start, but I just wanted you to look at it and give me your thoughts, I will be refining it next week.
The issues I have are that I would like to use the methods such as Set to set the values because it does a better job, with proper retries and such, but not quite sure how exactly to do that in your code. Do you have any suggestions? I would appreciate your comments.
This is using the solution recommended by memcached