Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ability to decorate or extend ICacheManager #176

Closed
erizzo opened this issue Jul 21, 2017 · 2 comments
Closed

Provide ability to decorate or extend ICacheManager #176

erizzo opened this issue Jul 21, 2017 · 2 comments
Assignees
Milestone

Comments

@erizzo
Copy link

erizzo commented Jul 21, 2017

I want to add some behavior (and state) to the out-of-the-box ICacheManager implementation. Normally I'd just write my own class that implements the interface, has a private field of the interface type that's passed in to the constructor, and implement the interface methods as calls to that field.
The problem is that ICacheManager has 60+ methods, making it impractical to implement. My second thought was to extend BaseCacheManager, but that class is sealed.

So I need a lightweight way to decorate the cache manager, still exposing all (well, most) of its methods. Simplest suggestion I can think of is to un-seal BaseCacheManager, but I wonder why it was sealed in the first place - maybe there's more than meets the eye in that decision.

@MichaCo
Copy link
Owner

MichaCo commented Jul 23, 2017

Hi @erizzo,
I will have a look why the BaseCacheManager is sealed, not really sure why this is as I usually don't like to have any sealed classes in public APIs if possible ^^. I'll probably remove it

@MichaCo
Copy link
Owner

MichaCo commented Nov 18, 2017

fixed in release 1.1.2

@MichaCo MichaCo closed this as completed Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants