Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing MemcachedClient for MemcachedHandle #118

Closed
themakshter opened this issue Dec 5, 2016 · 7 comments
Closed

Allow passing MemcachedClient for MemcachedHandle #118

themakshter opened this issue Dec 5, 2016 · 7 comments

Comments

@themakshter
Copy link

themakshter commented Dec 5, 2016

At the moment, the only way to pass in memcached settings for enyim is through adding these via the config settings. However, there may be circumstances where we might need to define our own MemcachedClient instance or something of the sort and set that in the CacheManager initiation. It would be nice to be able to pass in any object that implements IMemcachedClientConfiguration.

Adding Enyim's wiki page for reference

@MichaCo
Copy link
Owner

MichaCo commented Dec 5, 2016

Sure, that makes sense,
Will add it to my list ^^

MichaCo added a commit that referenced this issue Dec 5, 2016
@MichaCo MichaCo added this to the Version 0.9.3 milestone Dec 5, 2016
@MichaCo
Copy link
Owner

MichaCo commented Dec 6, 2016

@themakshter Turned out I actually need the feature myself faster as expected to test the memcached handle, so, this will be in the next release ;)

@themakshter
Copy link
Author

that's awesome! thank you very much!

@MichaCo
Copy link
Owner

MichaCo commented Jan 11, 2017

Added the same option to redis, too. Now you can pass in an existing connection multiplexer.
/closing this one as it will be released soon

@themakshter
Copy link
Author

themakshter commented Mar 14, 2017

Hey, just to check, does this mean you cannot now just pass in the enyim section like WithMemcachedHandle("enyim.com/memcached")?

I have been testing it, and when you just try to pass the section name to the WithMemcachedHandle method, you end up with a NullReferenceException

MichaCo added a commit that referenced this issue Mar 14, 2017
…ng version suffix to satisfy beta references (hopefully)
@MichaCo
Copy link
Owner

MichaCo commented Mar 14, 2017

@themakshter there is currently a bug in 0.9.3 unfortunately which causes that exception.
Actually it is a bug in the memcached client it seems, the ctor overload I'm using in that case doesn't initialize the client correctly.

The expected behavior is of course that it should also work with passing in the section name!

I reverted some changes back and it should work normal again in the next version.
Thanks for letting me know and sorry that I didn't catch it during testing ;)

@themakshter
Copy link
Author

No problem at all, it's good to know it got fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants