Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy #22

Merged
merged 13 commits into from
Mar 7, 2023
Merged

Deploy #22

merged 13 commits into from
Mar 7, 2023

Conversation

shakerAbuDrais
Copy link
Collaborator

In this PR, The following was implemented:

  1. Created a new render hosting env
  2. Used Active_storage with Google Cloud Storage to be able to save the images on an external server
  3. Amended the image_url method
  4. Changed the API end-points to match the new host link
  5. Added default host link in the routes file
  6. Changed the credentials, add google cloud storage credentials file, and fixed the migrations

Mhamad-Raad
Mhamad-Raad approved these changes Mar 7, 2023
View reviewed changes
Copy link
Owner

@Mhamad-Raad Mhamad-Raad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Congratulations, there is nothing left other than it is ready to merge,

@KanzaTahreem KanzaTahreem linked an issue Mar 7, 2023 that may be closed by this pull request
[2pt] Deploy the backend #5
Closed
1 task
@KanzaTahreem KanzaTahreem merged commit 3da6cf4 into dev Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mhamad-Raad Mhamad-Raad Mhamad-Raad approved these changes

Assignees

@shakerAbuDrais shakerAbuDrais

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt] Deploy the backend
3 participants
@shakerAbuDrais @Mhamad-Raad @KanzaTahreem