Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Vertical operators #31

Merged
merged 71 commits into from
Mar 6, 2023
Merged

Vertical operators #31

merged 71 commits into from
Mar 6, 2023

Conversation

petrabaumann
Copy link
Collaborator

No description provided.

@petrabaumann
add interpolation from k to pressure levels (linear in p)
b4bd8d2
@petrabaumann
add test for interpolation from k to p levels (linear in p)
dca8c44
@petrabaumann
add operator to compute potential temperature (theta)
1ae3bc9
@petrabaumann
add test for interpolation from k to p levels (linear in lnp), some c…
36b3ec2 
…lean-up
@petrabaumann
revise initialization and assignment of resulting field in interpolat…
a6dec12 
…ion to p
@petrabaumann
revise comment in operators/theta.py
98a13b5
@petrabaumann
add operator to interpolate from model (k) to theta levels
5a2a632
@petrabaumann
fix interpolation from model to pressure levels in nearest surface mo…
efab97c 
…de, add test
@petrabaumann
consider case that target theta levels are outside range of theta fie…
6c561d4 
…ld for interpolation from k to theta levels
@petrabaumann
consider case that target theta levels are outside range of theta fie…
471957b 
…ld for interpolation from k to pressure levels
@petrabaumann
consider case that hzerocl is located below the model ground surface
48d1835
@petrabaumann
minimize tolerances in unit tests for vertical interpolation
4b53b93
@petrabaumann
reduce number of arithmetic ops in fhzerocl, minimize tolerance in un…
555d188 
…it test
@petrabaumann
use only one fieldextra template to test interpolation from k to pres…
3b8e301 
…sure levels
@petrabaumann
use only one fieldextra template to test interpolation from k to pres…
bda6e66 
…sure levels (part 2)
@petrabaumann
use only one fieldextra template to test interpolation from k to thet…
40c30b6 
…a levels
@petrabaumann
test all modes for interpolation from k to pressure levels in one script
cc07134
@petrabaumann
some code consolidation of interpolation from k to pressure levels
37e103c
@petrabaumann
consolidate test scripts for interpolation from k to theta levels
8868b43
@petrabaumann
operators: add some documentation
864db41
@petrabaumann
operators: revise documentation of vertical interpolation
797ed53
@petrabaumann
src, test: correct level types for height fields on model layers and …
26da3e9 
…surfaces
@petrabaumann
operators: renamed some variables in vertical_interpolation for bette…
e9696a8 
…r readability
@petrabaumann
operators: replace hardcoded bottom level index by computation
de74551
@petrabaumann petrabaumann self-assigned this Sep 8, 2022
@cosunae
Copy link
Contributor

cosunae commented Sep 10, 2022

launch jenkins

cosunae
cosunae reviewed Sep 10, 2022
View reviewed changes
idpi/src/grib_decoder.py Outdated Show resolved Hide resolved
idpi/src/operators/brn.py Outdated Show resolved Hide resolved
idpi/src/operators/destagger.py Show resolved Hide resolved
idpi/src/operators/vertical_interpolation.py Outdated Show resolved Hide resolved
idpi/src/operators/vertical_interpolation.py Outdated Show resolved Hide resolved
idpi/src/operators/vertical_interpolation.py Outdated Show resolved Hide resolved
idpi/src/operators/vertical_interpolation.py Outdated Show resolved Hide resolved
idpi/src/operators/vertical_interpolation.py Outdated Show resolved Hide resolved
@cosunae
Copy link
Contributor

cosunae commented Sep 10, 2022

The jenkins tests are passing,
but the github actions for formatting are failing.
https://github.com/MeteoSwiss-APN/icon_data_processing_incubator/runs/8252730916?check_suite_focus=true
Could you fix it by just changing the version here

icon_data_processing_incubator/.github/workflows/precommit.yml

Line 19 in de08727

python-version: 3.10.4

to 3.10.6

The other action failing jake.yml you can remove is not really useful

@petrabaumann
operators: some simplification in vertical integration
c2f4c78
@petrabaumann
Merge branch 'main' into vertical_operators
6e31911 
Conflicts:
	.github/workflows/precommit.yml
	.pre-commit-config.yaml
@petrabaumann
precommit.yaml, .pre-commit-config.yaml: update to python 3.10.9
30f183e
@petrabaumann
operators, tests: changes by black, isort, flake8
eab254f
@petrabaumann
operators: revise comments in vertical_reduction
c57008a
@petrabaumann
operators, test: split reduce_k into two functions integrate_k and mi…
a22bb39 
…nmax_k
@petrabaumann
operators: rename init_field to init_field_with_vcoord, revise interface
59739e0
@petrabaumann
operators: rename variables in vertical interpolation to increase rea…
982a95f 
…dability
@petrabaumann
operators: check level type of input field in vertical interpolation
bbc4c0d
@petrabaumann
operators: revise/add some comments
99a38c7
@petrabaumann
operators: fix interpolate_k2p.py for interpolation to pressure level…
a0c2026 
…s partly below earth surface
@petrabaumann
operators: fix hzerocl to work also if the 0 deg isotherm falls partl…
be28f11 
…y below the earth's surface
@petrabaumann
operators: fix interpolate_k2theta to work also when theta levels fal…
c3f759b 
…l below the earth's surface
@petrabaumann
operators: fix formatting and linting
9a2d430
@petrabaumann
operators: update comments and target interval check in vertical_inte…
393b803 
…rpolation.py
@petrabaumann
operators: drop nan only for vertical dimension in vertical_reduction.py
d567006
@petrabaumann
operators: fix vertical dimension check in integrate_k
2e61b8e
@petrabaumann
operators: add some checks and update comments in vertical_interpolation
d0c8e58
@petrabaumann
operators: raise error if vertical reduction is called with mode invo…
4ded5a6 
…lving height agl due to missing unit test
@petrabaumann
operators: soothe flake8 to accept vertical_reduction after commentin…
6131edf 
…g not yet tested feature
cosunae
cosunae reviewed Feb 21, 2023
View reviewed changes
idpi/src/grib_decoder.py Show resolved Hide resolved
idpi/src/operators/destagger.py Show resolved Hide resolved
idpi/src/operators/hzerocl.py Show resolved Hide resolved
idpi/src/operators/vertical_reduction.py Outdated Show resolved Hide resolved
idpi/src/operators/vertical_reduction.py Show resolved Hide resolved
idpi/src/operators/vertical_reduction.py Show resolved Hide resolved
cosunae
cosunae approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@cosunae cosunae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can approve this, as we discussed the remaining issues can be taken out into an issue for future work

@petrabaumann petrabaumann merged commit 3fadf5a into main Mar 6, 2023
@cfkanesan cfkanesan deleted the vertical_operators branch July 11, 2023 12:31
This was referenced Apr 22, 2024
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cosunae cosunae cosunae approved these changes

Assignees

@petrabaumann petrabaumann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@petrabaumann @cosunae