Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Theme colors and dark/light mode context #2

Merged
merged 8 commits into from
Feb 22, 2021
Merged

Conversation

acollierr17
Copy link
Contributor

@acollierr17 acollierr17 commented Feb 18, 2021

I added the styles for the green and purple color themes. Feel free to discuss the color codes used:
- Green: #2ecc71 Screenshot
- Purple: #a846eb (already existed) Screenshot

Also, for handling automatic light/dark mode functionality, I initially wasn't too knowledgeable on the matter; therefore, if you look at the version history of applyMode.js, my change was useless. Today, I made it clear how the theme is to handle light/dark mode if the user's browser does not support the prefers-color-scheme CSS media query. However, if it's supported, the theme sets the color scheme based on a) their operating system's configured color scheme or b) their browser's color scheme override.

Stuff I still need to account for:

  • Apply color context to the sidebar's scrollbar
  • Apply color context to the Pacman loading icon
  • Apply color context to the loading/progress bar

@acollierr17 acollierr17 changed the title Green/purple theme colors + distinct theme usage Theme colors and dark/light mode context Feb 20, 2021
@t3ned
Copy link

t3ned commented Feb 22, 2021

I'm not knowledgeable with frontend. The new theme colours look great!

@acollierr17 acollierr17 merged commit 13990fa into master Feb 22, 2021
@acollierr17 acollierr17 deleted the patch/theme-colors branch February 22, 2021 23:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants