This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
Fix bug where day/time clock was ignored for light/dark theme #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the daylight cycle to work in the previous iteration, matches for both light and dark mode media queries had to return false for the daylight cycle to work. However, the previous implementation broke the daylight cycle check overall.
The comment in the previous iteration of this function stated this is accounted for if older browsers are being used. I don't think this is really needed anymore as it's 2020, and these guides are geared towards developers. The daylight cycle should now function as normal.
Also, I updated the README with checkboxes.