bfcfg: support additional UEFI settings #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # item. Also the capsule doesn't embed any driver. | ||
| # | ||
|
|
||
| local uefi_cap_hdr_len=32 |
There was a problem hiding this comment.
Is the header length 28 or 32 ? Because based on the capfile_len calculation below it is read from offset 24 with size 4 bytes which evaluates the size to 28 based on the EFI_CAPSULE_HEADER structure defined below
There was a problem hiding this comment.
Very good catch Mahantesh!
The capsule header is 28 bytes (packed) but there are extra 4 bytes padding. It is in reality 8 byte aligned, This is not obvious, though. You can refer to https://github.com/tianocore/edk2/blob/master/BaseTools/Source/Python/Common/Uefi/Capsule/UefiCapsuleHeader.py#L43
Let me add a comment to explain the reason why the the header length doesn't match the size of the data structure.
90a3b6c
to
21d5df2
Compare
This commit implements the following changes: * Improve UEFI Capsule header parsing; the existing parser doesn't support signed UEFI capsules. * Update control flags for Arm settings; add flags to manage UEFI secure boot settings and UEFI password settings. * Add extra Arm UEFI system attributes, i.e., SYS_ENABLE_I2C3, SYS_ENABLE_FORCE_BOOT_RETRY and SYS_ENABLE_OEM_MFG_CONFIG. * Support Arm UEFI Secure Boot PCP; to enroll UEFI secure boot certificate files. RM #4049059 RM #4049061 RM #3879059 RM #4063109 Fixes: c134069 ("bfcfg: enhance 'cfg2bin' command and add 'bin2cfg' command")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the following changes:
RM #4049059
RM #4049061
Fixes: c134069 ("bfcfg: enhance 'cfg2bin' command and add 'bin2cfg' command")