Add missing UEFI config options to bfcfg dump #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesphurl
previously requested changes
Jul 18, 2024
fe05545
to
e112ea2
Compare
|
Are the three commits expected or were you trying to update this pull request? If you are trying to update this pull request, you can run "git push origin master -f" against your fork. That should update the files in this pull request. |
kblaiech
reviewed
Aug 6, 2024
kblaiech
reviewed
Aug 6, 2024
kblaiech
reviewed
Aug 6, 2024
kblaiech
reviewed
Aug 6, 2024
@kblaiech Since Github has no way to track incremental changes on a code review using an ID like gitreview/git-master I'm using multiple commits to make reviewing easier. I'll squash them together before merging so it will look like a single commit on master. |
kblaiech
reviewed
Aug 21, 2024
kblaiech
reviewed
Aug 21, 2024
kblaiech
reviewed
Aug 21, 2024
92d7dc5
to
4e69914
Compare
lsun100
reviewed
Aug 24, 2024
4e69914
to
90a64e4
Compare
lsun100
reviewed
Sep 6, 2024
lsun100
approved these changes
Sep 6, 2024
11a9dc9
to
e564ef3
Compare
Add all missing UEFI config options to bfcfg dump so the bfcfg dump output can be used to compare defaults across releases. A verbose mode option has also been added to bfcfg to enable verbose dump outputs like the boot order and public keys/certificates used for secure boot. RM #3969767
e564ef3
to
11d42c4
Compare
lsun100
approved these changes
Sep 6, 2024
kblaiech
added a commit
to kblaiech/bfscripts
that referenced
this pull request
Sep 9, 2024
Fixes: 0042b84 ("Add missing UEFI config options to bfcfg dump (Mellanox#229)")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing UEFI config options to bfcfg dump so the bfcfg dump output can be used to compare defaults across releases. A dump level option has also been added to bfcfg to increase the amount of information dumped like the boot order and public keys/certificates used for secure boot.
RM #3969767