Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some models #8

Merged
merged 13 commits into from
Aug 31, 2020
Merged

Add some models #8

merged 13 commits into from
Aug 31, 2020

Conversation

nmaac
Copy link
Contributor

@nmaac nmaac commented Jul 31, 2020

I add two models:

  • FReLU
  • WeightNet

Copy link
Collaborator

@FateScript FateScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouyizhuang-megvii
Copy link
Collaborator

PTAL @zhouyizhuang-megvii

LGTM

transform = T.Compose([
T.Resize(256),
T.CenterCrop(224),
# T.Normalize(mean=[103.530, 116.280, 123.675], std=[57.375, 57.120, 58.395]), # BGR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然无需 normlize,是不是这行直接删除比较好

models/megengine_vision_frelu.md Show resolved Hide resolved
transform = T.Compose([
T.Resize(256),
T.CenterCrop(224),
# T.Normalize(mean=[103.530, 116.280, 123.675], std=[57.375, 57.120, 58.395]), # BGR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

既然无需 Normlize,那么请不要提交没用的注释代码,请删除

transform = T.Compose([
T.Resize(256),
T.CenterCrop(224),
# T.Normalize(mean=[103.530, 116.280, 123.675], std=[57.375, 57.120, 58.395]), # BGR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

transform = T.Compose([
T.Resize(256),
T.CenterCrop(224),
# T.Normalize(mean=[103.530, 116.280, 123.675], std=[57.375, 57.120, 58.395]), # BGR
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

models/megengine_vision_frelu.md Show resolved Hide resolved
@zhouyizhuang-megvii zhouyizhuang-megvii merged commit 169c622 into MegEngine:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants