Skip to content
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.

Mocha support in the runner #299

Open
mikesol opened this issue Oct 7, 2019 · 1 comment
Open

Mocha support in the runner #299

mikesol opened this issue Oct 7, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mikesol
Copy link

mikesol commented Oct 7, 2019

Currently, unmock hardcodes Jest error catching in the runner, which means that the runner will not work in mocha and other frameworks.

It would be great if the runner had conditionals for different frameworks, which would require testing different test failure cases for different packages and handling them in a similar manner.

The ugly thing about the way we do it is that we catch a JestAssertionError and treat that as the runner failing. JestAssertionError is an internal, undocumented way that jest causes tests to fail, so essentially we are creating a dependency on an internal API that could change in subsequent versions. It would be nice to address that to, and part of that could be asking the jest team to expose JestAssertionError in their external API so that it becomes a bit more sticky and less subject to change.

@mikesol mikesol added enhancement New feature or request good first issue Good for newcomers labels Oct 7, 2019
@mikesol mikesol changed the title Mocha support Mocha support in the runner Nov 22, 2019
@carolstran carolstran removed the good first issue Good for newcomers label Feb 5, 2020
@carolstran
Copy link
Contributor

carolstran commented Feb 11, 2020

Dropping this here to track progress!

TODO:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants