Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

PAT-1444: Fixed Step titles when editing steps #144

Merged
merged 3 commits into from
Dec 9, 2019
Merged

PAT-1444: Fixed Step titles when editing steps #144

merged 3 commits into from
Dec 9, 2019

Conversation

AbdallahMedable
Copy link
Collaborator

Objective

  • PAT-1444 Fixed Step titles when we edit steps that are part of ReviewStep.

How

  • By un-assigning the actionBar from navigation component, and clearing the actionBar title in case of editing, and showing it back when we go to ReviewStep

How To Test

  • Credentials:

    • Environment: int-dev
    • Org: abdallahandela
    • Study: Banadol

  • Steps:

    1. Open the app and use the credentials above
    2. Join Study
    3. Take task ReviewStep Boolean
    4. Reach to ReviewStep
    5. Edit any of the steps

  • Expected: the action bar must be empty, showing no title

Branches
  • PAT: task/PAT-1294-review-step
  • Axon: task/PAT-1294-review-step
  • RS: bug/PAT-1444_step_titles_incorrect_when_editing
  • Cortex: development

Links

Closes PAT-1444

Gryzor
Gryzor approved these changes Dec 9, 2019
View reviewed changes
Copy link

@Gryzor Gryzor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with both Ordered Tasks and Tasks with Branches. 👍

@AbdallahMedable AbdallahMedable merged commit 866c29f into task/PAT-1294-review-step Dec 9, 2019
@AbdallahMedable AbdallahMedable deleted the bug/PAT-1444_step_titles_incorrect_when_editing branch December 9, 2019 17:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Gryzor Gryzor Gryzor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@AbdallahMedable @Gryzor