Note volume timing fix #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges at the correct time when scheduling note playing
|
Thank you so much for submitting this fix as a PR, Linn! If you have any questions about the project or the code, I am available and I would be happy to answer them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed latency scheduling workaround and instead scheduled volume changes at the correct time when scheduling note playing.
My guess is that the latencyhint was a hack for some volume timing issues, since I got distortion/clipping when I removed it. In the latest version of tone.js however, latencyhint is read only / getter, and this hack no longer works.
Changing the scheduler to set the volume at the correct time seems to solve the issue, and works with the latest version of Tone.js