Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix note volume behavior #19

Closed
MaxLaumeister opened this issue Dec 24, 2019 · 0 comments
Closed

Fix note volume behavior #19

MaxLaumeister opened this issue Dec 24, 2019 · 0 comments
Assignees
@MaxLaumeister
Labels
bug Something isn't working
Milestone
1.0 Release

Comments

@MaxLaumeister
Copy link
Owner

Right now, note volume is set when the note is scheduled. Note volume needs to be set right before the note plays, according to the number of notes in the column.

This fixes the bug where the order notes are drawn in affects which notes play more loudly than others.
@MaxLaumeister MaxLaumeister added the bug Something isn't working label Dec 24, 2019
@MaxLaumeister MaxLaumeister added this to the 1.0 Release milestone Dec 24, 2019
@MaxLaumeister MaxLaumeister self-assigned this Dec 24, 2019
MaxLaumeister added a commit that referenced this issue Dec 24, 2019
@MaxLaumeister
Note volume behavior fixed. Closes #19
6b39d5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaxLaumeister MaxLaumeister

Labels
bug Something isn't working
Projects
None yet
Milestone
1.0 Release
Development

No branches or pull requests
1 participant
@MaxLaumeister