Prevent percent sign removal in flex/-ms-flex (fixes css#410)

Max4aters · Jan 20, 2020 · ac4b2ed · ac4b2ed
1 parent cb63229
commit ac4b2ed
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 1 deletion.
diff --git a/lib/replace/Percentage.js b/lib/replace/Percentage.js
@@ -7,7 +7,13 @@ var blacklist = new Set([
  'max-width',
  'height',
  'min-height',
- 'max-height'
+ 'max-height',
+
+ // issue #410: Don’t remove units in flex-basis value for (-ms-)flex shorthand
+ // issue #362: shouldn't remove unit in -ms-flex since it breaks flex in IE10/11
+ // issue #200: shouldn't remove unit in flex since it breaks flex in IE10/11
+ 'flex',
+ '-ms-flex'
 ]);
 
 module.exports = function compressPercentage(node, item) {

diff --git a/test/fixture/compress/issue/410.css b/test/fixture/compress/issue/410.css
@@ -0,0 +1,23 @@
+.flex {
+ flex: 1 0 0;
+}
+
+.flex-pct {
+ flex: 1 0 0%;
+}
+
+.flex-px {
+ flex: 1 0 0px;
+}
+
+.ms-flex {
+ -ms-flex: 1 0 0;
+}
+
+.ms-flex-pct {
+ -ms-flex: 1 0 0%;
+}
+
+.ms-flex-px {
+ -ms-flex: 1 0 0px;
+}
diff --git a/test/fixture/compress/issue/410.min.css b/test/fixture/compress/issue/410.min.css
@@ -0,0 +1 @@
+.flex{flex:1 0 0}.flex-pct{flex:1 0 0%}.flex-px{flex:1 0 0px}.ms-flex{-ms-flex:1 0 0}.ms-flex-pct{-ms-flex:1 0 0%}.ms-flex-px{-ms-flex:1 0 0px}