fix: dynamic storage info slow on windows #993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason I can't explain, the original order of fetching system information is slow using the Promise.all gathering method as opposed to two sequential awaits... The reversed order does not suffer from this performance issue though...
|
Okay, that is very weird. But thank you for investigating, and thank you for your contribution! |
|
For completeness, the impacted setup was a Windows 11 platform, this might vary on other system. Thanks for the quick merge! |
github-actions bot
added a commit
that referenced
this pull request
Jan 6, 2024
## [5.3.2](v5.3.1...v5.3.2) (2024-01-06) ### Bug Fixes * dynamic storage info slow on windows ([#993](#993)) ([64655f1](64655f1))
|
🎉 This issue has been resolved in version 5.3.2 Please check the changelog for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason I can't explain, the original order of fetching system information is slow using the Promise.all gathering method as opposed to two sequential awaits...
The reversed order does not suffer from this performance issue though...
Description
Related Issue(s)