Refactor ManualResetEvent to use PinList
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using my
PinListabstraction instead of theLinkedListabstraction,ManualResetEventcan be implemented in fully safe code. This is quite a benefit because it also makes it clear that it’s not UB (#56) — the fundamental problem is still there but because it’s abstracted in thePinListbypinned-aliasableI think it’s a lot more acceptable to have (and it also works under Miri).If there is interest, I would be happy to refactor more of the types provided by this crate to use
PinList— so far it’s just a proof-of-concept for the simplest one.