New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Sync for SharedStream #57

Open

jean-airoldie wants to merge 1 commit into Matthias247:master from jean-airoldie:shared_stream_sync

Contributor

jean-airoldie commented Feb 20, 2021

Basically I'm wondering whether SharedStream could unsafe impl Sync but I'm not sure this is sound.

The trait sync is defined as

The precise definition is: a type T is Sync if and only if &T is Send. In other words, if there is no possibility of undefined behavior (including data races) when passing &T references between threads.
https://doc.rust-lang.org/std/marker/trait.Sync.html

So in other words, T is sync if a Arc<T> shared across threads couldn't possibly trigger UB.

Since no operation that takes a &SharedStream affects the contained ChannelReceiveFuture, this should be safe.


implement Sync for SharedStream

bc5c28a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment