-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some countries has no cites #48
Comments
Hi, @Kenan-Hussein I think I understand your issues, this is happening because of the difference in the data source, do you think you can help identify any other country with this problem? |
@MartinsOnuoha Well.. that took some time but glad to help Here is your list: Syrian Arab Republic |
Thanks a lot @Kenan-Hussein , I'll get to work on fixing up these data, and raise a PR for it |
still not working can you please fix Syrian Arab Republic at less please |
Hey @Kenan-Hussein apologies, I've been trying to validate some of these countries and making sure their names haven't changed, yet, expect a fix today. |
unifies country names across model files Closes #48
@Kenan-Hussein |
* 🐛 (model) unifying country names unifies country names across model files Closes #48 * 🐛 (countryAndCities.js) adds norfolk island * adds Palau * adds sao tome * adds seirra leonne, refactor getCitiesByCountry func * adds wallis and futuna * fix vietnam
Using https://countriesnow.space/api/v0.1/countries/positions
return some countries name in a different way when using this :
https://countriesnow.space/api/v0.1/countries/info?returns=name
Example:
/positions response: syria as "Syrian Arab Republic"
/info?returns=name response: "Syria"
Using "Syrian Arab Republic" as post request to get its cities return nothing, but when using "Syria" it works, the problem I need to use positions to get lat and long also to get a country name to get it cities.
I noticed there are some other countries that have the same issue.
The text was updated successfully, but these errors were encountered: