Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Denormalize namespace name to job version table #935

Merged
merged 5 commits into from
Feb 10, 2021

Conversation

henneberger
Copy link
Contributor

  • Denormalize namespace name to job table
  • Add spotless
  • Denormalize namespace & job name to job_versions

@henneberger henneberger changed the title feature/job version denormalized Denormalize namespace name to job table Feb 10, 2021
@julienledem julienledem changed the title Denormalize namespace name to job table Denormalize namespace name to job version table Feb 10, 2021
Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #935 (67faf8e) into main (cae2ef0) will decrease coverage by 0.34%.
The diff coverage is 68.39%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #935      +/-   ##
============================================
- Coverage     72.88%   72.53%   -0.35%     
- Complexity      437      830     +393     
============================================
  Files           112      167      +55     
  Lines          2054     3780    +1726     
  Branches        188      360     +172     
============================================
+ Hits           1497     2742    +1245     
- Misses          269      568     +299     
- Partials        288      470     +182     
Impacted Files Coverage Δ Complexity Δ
api/src/main/java/marquez/MarquezException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
...src/main/java/marquez/MarquezRuntimeException.java 0.00% <ø> (ø) 0.00 <0.00> (?)
api/src/main/java/marquez/api/JobResource.java 84.90% <ø> (ø) 18.00 <0.00> (?)
...i/src/main/java/marquez/api/NamespaceResource.java 90.00% <ø> (ø) 5.00 <0.00> (?)
api/src/main/java/marquez/api/RunResource.java 92.30% <ø> (ø) 7.00 <0.00> (?)
api/src/main/java/marquez/api/SourceResource.java 88.88% <ø> (ø) 4.00 <0.00> (?)
api/src/main/java/marquez/api/TagResource.java 80.00% <ø> (ø) 2.00 <0.00> (?)
...rquez/api/exceptions/DatasetNotFoundException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...pi/exceptions/DatasetVersionNotFoundException.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...marquez/api/exceptions/FieldNotFoundException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
... and 185 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87b1031...67faf8e. Read the comment docs.

@wslulciuc wslulciuc merged commit 77d1404 into main Feb 10, 2021
@wslulciuc wslulciuc deleted the feature/job_version_denormalized branch February 10, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants