Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Source.type enum #919

Merged
merged 6 commits into from
Feb 4, 2021
Merged

Drop Source.type enum #919

merged 6 commits into from
Feb 4, 2021

Conversation

wslulciuc
Copy link
Member

This PR makes Source.type more dynamic by allowing the caller to provide the type instead of an enum.

See related proposal #698 and PR #916

Signed-off-by: wslulciuc <[email protected]>
@codecov
Copy link

codecov bot commented Feb 4, 2021

Codecov Report

Merging #919 (17b49ff) into main (2890368) will decrease coverage by 0.07%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #919      +/-   ##
============================================
- Coverage     73.42%   73.35%   -0.08%     
- Complexity      811      812       +1     
============================================
  Files           160      160              
  Lines          3594     3595       +1     
  Branches        322      324       +2     
============================================
- Hits           2639     2637       -2     
  Misses          538      538              
- Partials        417      420       +3     
Impacted Files Coverage Δ Complexity Δ
.../src/main/java/marquez/service/mappers/Mapper.java 62.91% <50.00%> (ø) 36.00 <0.00> (ø)
...rc/main/java/marquez/common/models/SourceType.java 70.00% <70.00%> (-30.00%) 2.00 <2.00> (+1.00) ⬇️
api/src/main/java/marquez/db/OpenLineageDao.java 90.43% <100.00%> (ø) 48.00 <1.00> (ø)
...i/src/main/java/marquez/service/SourceService.java 62.00% <100.00%> (ø) 9.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2890368...17b49ff. Read the comment docs.

@wslulciuc wslulciuc merged commit c956feb into main Feb 4, 2021
@wslulciuc wslulciuc deleted the feature/make-source-type-string branch February 4, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants