Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker/up.sh to allow for multiple flags #844

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Conversation

wslulciuc
Copy link
Member

This PR fixes docker/up.sh to allow for setting both --build and --seed. A usage flags is also introduced:

 $ ./docker/up.sh --help
usage: ./up.sh [--build] [--seed]

This PR also uses the latest marquez-web image when running docker/up.sh and builds from source when using the --build flag.

@wslulciuc wslulciuc added the review Ready for review label Nov 19, 2020
@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #844 (1faf782) into main (7f5a96d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #844   +/-   ##
=========================================
  Coverage     73.10%   73.10%           
  Complexity      436      436           
=========================================
  Files           112      112           
  Lines          2049     2049           
  Branches        187      187           
=========================================
  Hits           1498     1498           
  Misses          264      264           
  Partials        287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f5a96d...c9f0c3a. Read the comment docs.

Copy link
Member

@phixMe phixMe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this up. Works on my side with both, either, and no flags.

@wslulciuc wslulciuc merged commit 2d51436 into main Nov 19, 2020
@wslulciuc wslulciuc deleted the bug/seeding-with-up.sh branch November 19, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants