Web/add dataset drawer #2672
Merged
Web/add dataset drawer #2672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 28, 2023 16:57
Signed-off-by: sharpd <[email protected]>
Signed-off-by: sharpd <[email protected]>
✅ Deploy Preview for peppy-sprite-186812 canceled.
|
|
@phixMe @wslulciuc - this is what I was talking about. It's a bit of hack but you get the idea. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2672 +/- ##
=========================================
Coverage 84.08% 84.08%
Complexity 1379 1379
=========================================
Files 248 248
Lines 6295 6295
Branches 286 286
=========================================
Hits 5293 5293
Misses 849 849
Partials 153 153 ☔ View full report in Codecov by Sentry. |
Signed-off-by: sharpd <[email protected]>
Signed-off-by: sharpd <[email protected]>
phixMe
reviewed
Nov 27, 2023
| elevation={0} | ||
| anchor='right' | ||
| open={open} | ||
| onClose={handleClose} |
There was a problem hiding this comment.
This is only used in one place, so you shouldn't need a wrapper function.
phixMe
reviewed
Nov 27, 2023
| anchor='right' | ||
| open={open} | ||
| onClose={handleClose} | ||
| sx={{ zIndex: 1300 }} |
There was a problem hiding this comment.
Can you reference a variable for this in the theme?
There was a problem hiding this comment.
yeah cool will move this out.
There was a problem hiding this comment.
Cool will fix this up.
Signed-off-by: sharpd <[email protected]>
yanlibert
pushed a commit
to libertyann/marquez
that referenced
this pull request
Dec 7, 2023
* add drawer to Dataset info on click Signed-off-by: sharpd <[email protected]> * update drawer formatting/revert chips to row Signed-off-by: sharpd <[email protected]> * fix logic errors in description Signed-off-by: sharpd <[email protected]> * add icon fo visual drawer cue Signed-off-by: sharpd <[email protected]> * update code based on feedback. Refer to theme values remove function. Signed-off-by: sharpd <[email protected]> --------- Signed-off-by: sharpd <[email protected]> Co-authored-by: sharpd <[email protected]> Signed-off-by: yanlibert <[email protected]>
yanlibert
pushed a commit
to libertyann/marquez
that referenced
this pull request
Dec 8, 2023
* add drawer to Dataset info on click Signed-off-by: sharpd <[email protected]> * update drawer formatting/revert chips to row Signed-off-by: sharpd <[email protected]> * fix logic errors in description Signed-off-by: sharpd <[email protected]> * add icon fo visual drawer cue Signed-off-by: sharpd <[email protected]> * update code based on feedback. Refer to theme values remove function. Signed-off-by: sharpd <[email protected]> --------- Signed-off-by: sharpd <[email protected]> Co-authored-by: sharpd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
An idea to move some column level attributes to a side drawer to make better use of screen real estate and with a view of adding additional column level information.
Solution
Add a drawer which displays column level information (tags at the moment) on the right hand of the screen when a column is selected. Use an accordion to allow hide/expand data elements.
One-line summary:
Add drawer to dataset column view.
Checklist
CHANGELOG.md(Depending on the change, this may not be necessary)..sqldatabase schema migration according to Flyway's naming convention (if relevant)