Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add deployment security expectations #2250

Merged
merged 5 commits into from
Nov 15, 2022

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Nov 15, 2022

Problem

Our Deployment Overview page is missing deployment security expectations.

Solution

Add missing deployment security expectations to our Deployment Overview page.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)
  • You've included a header in any source code files (if relevant)

@wslulciuc wslulciuc added the review Ready for review label Nov 15, 2022
@boring-cyborg boring-cyborg bot added the docs label Nov 15, 2022
@wslulciuc wslulciuc enabled auto-merge (squash) November 15, 2022 22:36
@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #2250 (1653eaa) into main (3998e05) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2250   +/-   ##
=========================================
  Coverage     76.72%   76.72%           
  Complexity     1147     1147           
=========================================
  Files           219      219           
  Lines          5318     5318           
  Branches        423      423           
=========================================
  Hits           4080     4080           
  Misses          763      763           
  Partials        475      475           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wslulciuc wslulciuc merged commit a7f88b0 into main Nov 15, 2022
@wslulciuc wslulciuc deleted the feature/deployment-security-expectations branch November 15, 2022 23:16
Copy link
Collaborator

@merobi-hub merobi-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wslulciuc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants