Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flywaydb to v7.6.0 #1974

Conversation

dakshin-k
Copy link
Contributor

@dakshin-k dakshin-k commented May 1, 2022

Problem

Flywaydb changed the public migrate API to return an object instead of a raw integer. This updates the migration script to use the new API.

Closes: #1052

Solution

Incorporated the API change and bumped the Flyway version in api/build.gradle.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

Signed-off-by: Dakshin Karthikeyan <[email protected]>
@dakshin-k dakshin-k force-pushed the dependency/org.flywaydb-flyway-core-7.6.0 branch from caee583 to a821bd2 Compare May 1, 2022 14:19
@codecov
Copy link

codecov bot commented May 1, 2022

Codecov Report

Merging #1974 (8a10284) into main (e9f7e56) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1974   +/-   ##
=========================================
  Coverage     78.23%   78.23%           
  Complexity      955      955           
=========================================
  Files           194      194           
  Lines          5292     5293    +1     
  Branches        420      420           
=========================================
+ Hits           4140     4141    +1     
  Misses          706      706           
  Partials        446      446           
Impacted Files Coverage Δ
api/src/main/java/marquez/db/DbMigration.java 36.36% <100.00%> (+1.98%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@dakshin-k
Copy link
Contributor Author

I'm not sure if this change needs an entry in CHANGELOG.md - have added it anyway, can delete it if it's unnecessary.

@@ -8,6 +8,10 @@
* Enable pod specific annotations in Marquez Helm Chart via `marquez.podAnnotations` [@wslulciuc](https://github.com/wslulciuc)
* Add support for job renaming/redirection via symlink [@collado-mike](https://github.com/collado-mike)

### Changed

* Upgrade Flyway to v7.6.0 [@dakshin-k](https://github.com/dakshin-k)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dakshin-k for getting Marquez on the latest and greatest of flyway 💯 🥇

@wslulciuc wslulciuc merged commit 1e3110e into MarquezProject:main May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API tests break when bumping org.flywaydb:flyway-core to v7
2 participants