Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker-compose setup to use volumes to support remote docker hosts #1957

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

collado-mike
Copy link
Collaborator

Problem

If you're using a remote docker host, you can't mount local directories to the running container, which makes it impossible to run the wait-for-it.sh and init-db.sh scripts. This updates the up.sh script to create volumes and copy the scripts, then mount those volumes to the containers. This makes development friendly for both local Docker installations and remote docker hosts.

Note: All database schema changes require discussion. Please link the issue for context.

Checklist

  • You've signed-off your work
  • Your changes are accompanied by tests (if relevant)
  • Your change contains a small diff and is self-contained
  • You've updated any relevant documentation (if relevant)
  • You've updated the CHANGELOG.md with details about your change under the "Unreleased" section (if relevant, depending on the change, this may not be necessary)
  • You've versioned your .sql database schema migration according to Flyway's naming convention (if relevant)

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #1957 (368e49c) into main (24786cb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #1957   +/-   ##
=========================================
  Coverage     78.09%   78.09%           
  Complexity      944      944           
=========================================
  Files           193      193           
  Lines          5249     5249           
  Branches        418      418           
=========================================
  Hits           4099     4099           
  Misses          705      705           
  Partials        445      445           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@wslulciuc wslulciuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@wslulciuc wslulciuc merged commit 335aa5f into main Apr 20, 2022
@wslulciuc wslulciuc deleted the docker_volumes branch April 20, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants