Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add api and admin port overrides in docker/up.sh #1583

Merged
merged 5 commits into from
Aug 20, 2021

Conversation

wslulciuc
Copy link
Member

@wslulciuc wslulciuc commented Aug 19, 2021

This PR adds the args --api-port and --api-admin-port to ./docker/up.sh:

$ ./docker/up.sh --help
usage: ./up.sh [--api-port PORT] [--web-port PORT] [--tag TAG] [--build] [--seed]
A script used to run Marquez via Docker

EXAMPLES:
  # Build image from source
  $ ./up.sh --build

  # Build image from source, then seed HTTP API server with metadata
  $ ./up.sh --build --seed

  # Use tagged image
  ./up.sh --tag X.Y.X

  # Use tagged image, then seed HTTP API server with metadata
  ./up.sh --tag X.Y.X --seed

  # Set HTTP API server port
  ./up.sh --api-port 9000

ARGUMENTS:
  -a, --api-port int          api port (default: 5000)
  -m, --api-admin-port int    api admin port (default: 5001)
  -w, --web-port int          web port (default: 3000)
  -t, --tag string            image tag (default: latest)

FLAGS:
  -b, --build           build images from source
  -s, --seed            seed HTTP API server with metadata
  -h, --help            show help for script

Example

$ ./docker/up.sh --api-port 9000 --api-admin-port 9001 --web-port 6000 --seed --build
$ docker ps
CONTAINER ID   IMAGE                               COMMAND                  CREATED          STATUS          PORTS                                                                          NAMES
4e9cfb885748   marquezproject/marquez:latest       "./wait-for-it.sh ap…"   29 seconds ago   Up 26 seconds   5000-5001/tcp                                                                  seed-marquez-with-metadata
e4fb3fa04347   marquezproject/marquez-web:latest   "/usr/src/app/entryp…"   29 seconds ago   Up 24 seconds   3000/tcp, 0.0.0.0:6000->6000/tcp, :::6000->6000/tcp                            marquez-web
d9ff887afdf2   marquezproject/marquez:latest       "./wait-for-it.sh db…"   33 seconds ago   Up 28 seconds   5000-5001/tcp, 0.0.0.0:9000-9001->9000-9001/tcp, :::9000-9001->9000-9001/tcp   marquez-api
e5a951c559bf   postgres:12.1                       "docker-entrypoint.s…"   37 seconds ago   Up 33 seconds   0.0.0.0:5432->5432/tcp, :::5432->5432/tcp                                      marquez-db

Fixes #1572

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #1583 (de581d1) into main (aa43289) will not change coverage.
The diff coverage is n/a.

❗ Current head de581d1 differs from pull request most recent head 1fff8f5. Consider uploading reports for the commit 1fff8f5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1583   +/-   ##
=========================================
  Coverage     78.63%   78.63%           
  Complexity      959      959           
=========================================
  Files           188      188           
  Lines          5191     5191           
  Branches        415      415           
=========================================
  Hits           4082     4082           
  Misses          670      670           
  Partials        439      439           
Impacted Files Coverage Δ
...nts/java/src/main/java/marquez/client/Clients.java 20.00% <0.00%> (ø)
...in/java/marquez/client/MarquezWriteOnlyClient.java 100.00% <0.00%> (ø)
...ava/marquez/client/MarquezWriteOnlyClientImpl.java 84.61% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa43289...1fff8f5. Read the comment docs.

@wslulciuc wslulciuc added the review Ready for review label Aug 19, 2021
@wslulciuc wslulciuc marked this pull request as ready for review August 19, 2021 18:12
Copy link
Collaborator

@rossturk rossturk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wslulciuc wslulciuc enabled auto-merge (squash) August 20, 2021 23:15
@wslulciuc wslulciuc merged commit e9d79f6 into main Aug 20, 2021
@wslulciuc wslulciuc deleted the feature/docker-port-overrides branch August 20, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port 5000 is no longer available for use in macOS Monterey
3 participants