Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --tag arg to docker/up.sh #1413

Merged
merged 4 commits into from
Jun 16, 2021

Conversation

wslulciuc
Copy link
Member

This PR adds the --tag arg to docker/up.sh. This PR also adds the --help flag to print the following script usage:

$ ./docker/up.sh --help
usage: ./up.sh [--tag TAG] [--build] [--seed]

A script used to run Marquez via Docker

Examples:
  # Build image from source
  $ ./up.sh --build

  # Build image from source, then seed HTTP server with metadata
  $ ./up.sh --build --seed

  # Build tagged image
  ./up.sh --tag X.Y.X

  # Build tagged image, then seed HTTP server with metadata
  ./up.sh --tag X.Y.X --seed


Arguments:
  -t, --tag string      image tag (ex: X.Y.Z, X.Y.Z-rc.*)
  -b, --build           build image from source
  -s, --seed            seed HTTP server with metadata
  -h, --help            show help for script

Signed-off-by: wslulciuc <[email protected]>
@wslulciuc wslulciuc added the review Ready for review label Jun 16, 2021
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #1413 (0abb886) into main (e18125e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1413   +/-   ##
=========================================
  Coverage     79.83%   79.83%           
  Complexity      915      915           
=========================================
  Files           197      197           
  Lines          5738     5738           
  Branches        392      392           
=========================================
  Hits           4581     4581           
  Misses          738      738           
  Partials        419      419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e18125e...0abb886. Read the comment docs.

@wslulciuc wslulciuc enabled auto-merge (squash) June 16, 2021 21:17
@wslulciuc wslulciuc removed the review Ready for review label Jun 16, 2021
@wslulciuc wslulciuc merged commit 68270af into main Jun 16, 2021
@wslulciuc wslulciuc deleted the feature/add-version-arg-to-docker-up-script branch June 16, 2021 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants