Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated NodeId regex to support URIs with scheme and ports #1176

Merged
merged 2 commits into from
Mar 31, 2021

Conversation

collado-mike
Copy link
Collaborator

Missed in the port of the lineage API- the NodeId splits on :, which causes dataset name parsing issues when dealing with URIs (e.g., gs:https://bucket/path or postgres:https://host:port/database).

@collado-mike collado-mike enabled auto-merge (squash) March 31, 2021 21:21
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1176 (d6cb1e1) into main (1f20123) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #1176   +/-   ##
=========================================
  Coverage     74.44%   74.44%           
  Complexity      803      803           
=========================================
  Files           180      180           
  Lines          4790     4790           
  Branches        368      368           
=========================================
  Hits           3566     3566           
  Misses          852      852           
  Partials        372      372           
Impacted Files Coverage Δ Complexity Δ
...i/src/main/java/marquez/service/models/NodeId.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f20123...d6cb1e1. Read the comment docs.

@collado-mike collado-mike merged commit 587a470 into main Mar 31, 2021
@collado-mike collado-mike deleted the node_id_split_regex branch March 31, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants