Remove un-used renameSlot method #2286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bibhu107 , thank you for contributing to Markbind! 🥳 We usually try to fix one issue per PR to avoid unrelated changes and keep a trackable history. Would you mind ensuring that this PR fixes only one issue? You could tackle another issue (not tagged "good first issue") if you're feeling up to it - we try to have one "good first issue" per contributor to encourage more new contributors :) If you'd like to fix more than one, feel free to open second PR! Would be nice if you could fill in the template given in the issue description as well, especially the proposed commit message! (To check a checkbox, you can fill it in with an 'x', e.g. |
This reverts commit 67a84cd.
|
@all-contributors please add @bibhu107 for code |
|
I've put up a pull request to add @bibhu107! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Fixes #2284
Overview of changes:
Anything you'd like to highlight/discuss:
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Remove un-used renameSlot method
Checklist: ☑️