Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CentralPackageVersioning in samples to simplify maintenance #3207

Closed
TheCakeMonster opened this issue Nov 14, 2022 · 2 comments · Fixed by #4082
Closed

Use CentralPackageVersioning in samples to simplify maintenance #3207

TheCakeMonster opened this issue Nov 14, 2022 · 2 comments · Fixed by #4082
Assignees
@kant2002 @sshushliapin
Labels
area/samples kind/enhancement

Comments

@TheCakeMonster
Copy link
Contributor

Central package versioning is now a first class citizen of .NET, and make management of things like sample applications easier. It probably makes sense to change over the samples to make use of this scheme so that they are easier to keep upgraded to the newer versions of CSLA.

https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management

I realised this whilst working on the compilation error we ended up with in the Blazor sample apps. I ended up having to change version numbers in multiple places, which is no longer necessary.

Suggested Solution
Upgrade each sample application separately, so that we can upgrade them one at a time. In the longer term we might decide that refactoring the samples folder makes sense to enable even simpler upgrades. However, being too aggressive may make upgrades larger, and hinder progress rather than enable it.

Further Improvement
The two Blazor samples BlazorExample and BlazorServerExample share backend packages, but are separate apps. I would suggest that moving both into a Blazor subfolder, so that the Directory.Packages.props file can apply to both, would be even better; this ensures that they are more likely to both compile together. See #3204 for an example of the current problem - upgrading just one of the two sample apps breaks the other.
@sshushliapin sshushliapin mentioned this issue Jun 15, 2024
Merged
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 15, 2024
Uses CentralPackageVersioning for BlazorExample
d460770 
(MarimerLLC#3207)
@sshushliapin sshushliapin mentioned this issue Jun 15, 2024
Merged
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 15, 2024
@sshushliapin
Uses CentralPackageVersioning for BlazorExample
cfb9f80 
(MarimerLLC#3207)
rockfordlhotka pushed a commit that referenced this issue Jun 15, 2024
@sshushliapin
#3207 Use CentralPackageVersioning in samples: ProjectTracker (#4035)
3e2dbc8 
* Move NuGet versions to Directory.Packages.props

* Introduce CslaVersion property

---------

Co-authored-by: Serhii Shushliapin <[email protected]>
rockfordlhotka added a commit that referenced this issue Jun 15, 2024
@sshushliapin @rockfordlhotka
Uses CentralPackageVersioning for BlazorExample (#4036)
8a8f853 
(#3207)

Co-authored-by: Serhii Shushliapin <[email protected]>
Co-authored-by: Rockford Lhotka <[email protected]>
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 16, 2024
Use Central Package Management in SimpleNTier
48900dc 
(MarimerLLC#3207)
@sshushliapin sshushliapin mentioned this issue Jun 17, 2024
Merged
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Convert projects into SDK style (MarimerLLC#3207)
f1490cb
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Remove app.config and packages.config files (MarimerLLC#3207)
039a216
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Remove unnecessary nuget packages (MarimerLLC#3207)
6528989
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Remove AssemplyInfo.cs (MarimerLLC#3207)
a821d59
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Remove analyzers which point to old packages folder (MarimerLLC#3207)
106fbca
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Remove OutputType Library which is default (MarimerLLC#3207)
daf891a
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
Introduce Directory.Packages.props (MarimerLLC#3207)
550434a
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Convert projects into SDK style
00b2dfd
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Remove app.config and packages.config files
3a6ab70
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Remove unnecessary nuget packages
55c9af4
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Remove AssemplyInfo.cs
32b1747
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Remove analyzers which point to old packages folder
f8e6437
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Remove OutputType Library which is default
2441089
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
\MarimerLLC#3207 Introduce Directory.Packages.props
b234f2c
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
MarimerLLC#3207 Convert projects into SDK style
c024ba3
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
MarimerLLC#3207 Remove app.config and packages.config files
97fb03c
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
MarimerLLC#3207 Remove unnecessary nuget packages
5a3518f
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
MarimerLLC#3207 Remove AssemplyInfo.cs
e19e662
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
MarimerLLC#3207 Remove analyzers which point to old packages folder
8645903
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 17, 2024
MarimerLLC#3207 Remove OutputType Library which is default
fac9ac2
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 19, 2024
MarimerLLC#3207 Introduce Directory.Packages.props
d765798
@sshushliapin sshushliapin mentioned this issue Jun 19, 2024
Merged
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 19, 2024
MarimerLLC#3207 Introduce Directory.Packages.props
0cf18db
rockfordlhotka pushed a commit that referenced this issue Jun 19, 2024
@sshushliapin
#3207 Use Central Package Management (CPM) in PropertyStatus solution (…
dde8da2 
…#4050)

* #3207 Convert into SDK project format

* #3207 Introduce Directory.Packages.props

---------

Co-authored-by: Serhii Shushliapin <[email protected]>
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 19, 2024
MarimerLLC#3207 Convert into SDK project format
5d9852e
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 19, 2024
MarimerLLC#3207 Introduce Directory.Packages.props
664cf83
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jun 19, 2024
MarimerLLC#3207 Fix base Docker images
fba8aac
@sshushliapin sshushliapin mentioned this issue Jun 19, 2024
Merged
rockfordlhotka pushed a commit that referenced this issue Jun 19, 2024
@sshushliapin
#3207 Use Central Package Management (CPM) in RoutedDataPortal soluti…
3f19935 
…on (#4052)

* #3207 Convert into SDK project format

* #3207 Introduce Directory.Packages.props

* #3207 Fix base Docker images

---------

Co-authored-by: Serhii Shushliapin <[email protected]>
@sshushliapin
Copy link
Contributor

@TheCakeMonster, @rockfordlhotka, do you have any opinion if it makes any sense to introduce CPM in single-project sample solutions such as DataPortalCacheExample? I ignored them for now, since for me it looks redundant... At the same time, if consistency is more important, I can come up with a single PR that introduces CPM for all the simple .net8 based solutions (for the .net8 projects there is much less work needed so a single PR should be ok).

@rockfordlhotka
Copy link
Member

I don't see any value in that case, just added complexity.

kant2002 added a commit to kant2002/csla that referenced this issue Jul 1, 2024
@kant2002
Remove redundant imports
385e63f 
They produce following errors (for all projects in the solution)
```
C:\d\github\csla\Samples\BlazorExample\BlazorExample\DataAccess\DataAccess.csproj(7,3): warning MSB4011: "C:\d\github\csla\Samples\BlazorExample\Directory.Packages.props" cannot be imported again. It was alre
ady imported at "C:\Program Files\dotnet\sdk\8.0.300\NuGet.props (35,3)". This is most likely a build authoring error. This subsequent import will be ignored.
```

Related to MarimerLLC#3207
@kant2002 kant2002 mentioned this issue Jul 1, 2024
Merged
rockfordlhotka pushed a commit that referenced this issue Jul 1, 2024
@kant2002
Remove redundant imports (#4073)
9f160ab 
They produce following errors (for all projects in the solution)
```
C:\d\github\csla\Samples\BlazorExample\BlazorExample\DataAccess\DataAccess.csproj(7,3): warning MSB4011: "C:\d\github\csla\Samples\BlazorExample\Directory.Packages.props" cannot be imported again. It was alre
ady imported at "C:\Program Files\dotnet\sdk\8.0.300\NuGet.props (35,3)". This is most likely a build authoring error. This subsequent import will be ignored.
```

Related to #3207
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 3, 2024
MarimerLLC#3207 Convert into SDK project format
2f6f6b5
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 3, 2024
MarimerLLC#3207 Introduce Directory.Packages.props
149629f
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 3, 2024
MarimerLLC#3207 Upgrade to .net 8.0
62d449b
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 3, 2024
MarimerLLC#3207 Convert into SDK project format
09770ab
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 3, 2024
MarimerLLC#3207 Introduce Directory.Packages.props
8f1d71c
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 3, 2024
MarimerLLC#3207 Upgrade to .net 8.0
ab1aee1
@sshushliapin sshushliapin mentioned this issue Jul 3, 2024
Merged
rockfordlhotka pushed a commit that referenced this issue Jul 3, 2024
@sshushliapin
#3207 Use Central Package Management (CPM) in RuleTutorial (#4076)
64fbf44 
* #3207 Convert into SDK project format

* #3207 Introduce Directory.Packages.props

* #3207 Upgrade to .net 8.0

---------

Co-authored-by: Serhii Shushliapin <[email protected]>
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 6, 2024
MarimerLLC#3207 Convert into SDK project format
6a42024
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 6, 2024
MarimerLLC#3207 Introduce Directory.Packages.props
b600953
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 6, 2024
MarimerLLC#3207 Restore missing NuGet packages and references
0cd98e3
sshushliapin pushed a commit to sshushliapin/csla that referenced this issue Jul 6, 2024
MarimerLLC#3207 Fix build configuration error
ccb3cb1
@sshushliapin sshushliapin mentioned this issue Jul 6, 2024
Merged
rockfordlhotka pushed a commit that referenced this issue Jul 6, 2024
@sshushliapin
#3207 Use Central Package Management (CPM) in SimpleNTier (#4082)
d670d36 
* #3207 Convert into SDK project format

* #3207 Introduce Directory.Packages.props

* #3207 Restore missing NuGet packages and references

* #3207 Fix build configuration error

---------

Co-authored-by: Serhii Shushliapin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kant2002 kant2002

@sshushliapin sshushliapin

Labels
area/samples kind/enhancement
Projects
CSLA Version 9.0.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#3207 Use Central Package Management (CPM) in SimpleNTier sshushliapin/csla
4 participants
@rockfordlhotka @kant2002 @sshushliapin @TheCakeMonster