Skip to content

Commit

Permalink
Revert "Adding support for Polars structs" (nushell#11171)
Browse files Browse the repository at this point in the history
Reverts nushell#10943

The current implementation of `arr_to_value` is unsound, as it allows
casts of arbitrary data to arbitrary types without being marked
`unsafe`.
The full safety requirements to perform both the cast and the following
unchecked access are not as clear that a simple change of `fn
arr_to_value` to `unsafe fn arr_to_value` could be blessed without
further investigation.

cc @ayax79
  • Loading branch information
sholderbach committed Nov 29, 2023
1 parent 9895208 commit 112306a
Show file tree
Hide file tree
Showing 3 changed files with 118 additions and 692 deletions.
1 change: 0 additions & 1 deletion Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion crates/nu-cmd-dataframe/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ nu-protocol = { path = "../nu-protocol", version = "0.87.2" }

# Potential dependencies for extras
chrono = { version = "0.4", features = ["std", "unstable-locales"], default-features = false }
chrono-tz = "0.8"
fancy-regex = "0.11"
indexmap = { version = "2.1" }
num = { version = "0.4", optional = true }
Expand Down
Loading

0 comments on commit 112306a

Please sign in to comment.