MDEV-34191: Make sure that Debian respects systemd disabled #3268
Conversation
illuusio
force-pushed
the
10.11-MDEV-34191-systemd-disable-fix
branch
2 times, most recently
from
fc74665
to
3509b42
Compare
debian/rules
Outdated
| dh $@ --parallel --with systemd --fail-missing | ||
| dh $@ --parallel |
There was a problem hiding this comment.
Why was --fail-missing removed?
Per https://manpages.debian.org/testing/debhelper/dh_missing.1.en.html
Please note that in compat 11 and earlier without either of these options, dh_missing will silently do nothing. In compat 12, --list-missing is the default. In compat 13 and later, --fail-missing is the default.
From my understanding, this change will make it so that the build process will no longer fail on missing files. Is this intended and safe?
There was a problem hiding this comment.
I'll add it back as we are using compat 11 not compat 12 which is not building on Debian 10 proberly.
illuusio
force-pushed
the
10.11-MDEV-34191-systemd-disable-fix
branch
2 times, most recently
from
f3bdfc8
to
489d7c5
Compare
|
Testing should or should not we have this restart thing but noted that we should not as it was.. so revert to that as this test has passed |
illuusio
force-pushed
the
10.11-MDEV-34191-systemd-disable-fix
branch
from
489d7c5
to
332c93e
Compare
I assume your referring to the According to https://man7.org/linux/man-pages/man1/dh_installsystemd.1.html, the The test failures are unrelated. Changes look good but I will leave it to someone with more experience with Debian packaging for a further review. |
|
Thank you having read documentation more than me! Yes failures are unrelated to this. I'll update the bb branch to get the Deb packages for testing |
Make sure that Debian respects systemd disabled by bumping to deb compat 11 which is available from Debian 10 and Ubuntu 20.04 and it provides better integration with systemd. Start using dh_installsystemd which is new recommended way in compat 11
illuusio
force-pushed
the
10.11-MDEV-34191-systemd-disable-fix
branch
from
332c93e
to
e891fce
Compare
Description
Make sure that Debian respects systemd disabled by bumping to deb compat 11 which is available in Debian 10 and Ubuntu 20.04 and it provides better integration with systemd.
Start using dh_installsystemd which is new recommended way in compat 11
Release Notes
Update Debian deb compat to 12
How can this PR be tested?
Basing the PR against the correct MariaDB version
PR quality check