MDEV-33863: New mysqladmin command tls-info #3247
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since TLSv1.0 is no longer supported in C/C 3.4, TLS1.0 tests which were expected to fail are removed.
Added new command tls-info which provides the following information: Cipher suite in use TLS protocol version Peer certificate information: - Version - Subject - Issuer - Valid not before/after - SHA256 finger print
Since TLSv1.0 is no longer supported in C/C 3.4, TLS1.0 tests which were expected to fail are removed.
Added new command tls-info which provides the following information: Cipher suite in use TLS protocol version Peer certificate information: - Version - Subject - Issuer - Valid not before/after - SHA256 finger print
|
|
grooverdan
approved these changes
May 9, 2024
| new_line=1; | ||
| char *version; | ||
|
|
||
| printf("Cipher suite:\t%s\n", mysql_get_ssl_cipher(mysql)); |
There was a problem hiding this comment.
This is calling the same pure function a second time, but I guess its ok since the C/C function is so shallow.
| info->not_after.tm_hour, info->not_after.tm_min); | ||
| printf("SHA256 fingerprint: %s\n", info->fingerprint); | ||
| } else { | ||
| my_printf_error(0, "Unable to retrieve peer certificate", 0); |
There was a problem hiding this comment.
indenting error. And style would say { on the next line.
There was a problem hiding this comment.
Just for verbosity the CODING STANDARDS link in the PR template provides the coding style guideline and coding standards in general.
| my_printf_error(0, "Unable to retrieve peer certificate", 0); | ||
| return 1; | ||
| } | ||
| } else { |
| @@ -1 +1 @@ | |||
| --tls_version=TLSv1.0 | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new command tls-info for mysqladmin client tool, which provides information for the TLS connection in use.
Release Notes
mysqladmin: Added a new command
tls-infowhich returns the following information:How can this PR be tested?
There is no test for, since the output depends on the certificate used by peer.
Feature can be tested by executing mysqladmin with command tls-info.
Basing the PR against the correct MariaDB version
PR quality check