MDEV-33750: Rename variables which are mysql_ to mariadb_ in Debian directory #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is MariaDB then also variable names in mariadb-server.*inst should correlate when possible this change variable and directory names
Make sure that we don't brand ourself mysql continue to drive branding things from mysql to mariadb in Debian directory
5 tasks
|
This makes sense, just wondering why target stable 10.11 branch? Perhaps this should go in 11.4 or 11.5 instead? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This more about branding PR. As in many places when reading Debian scripts MariaDB is mentioned as MySQL (
mysql_). As MariaDB is something else than MySQL (besides being mostly compatible upgrade path) it should be proudly be just MariaDB named variables indebian/directory and get rid of other naming. There is also couple other changes underdebian/to brand this more.Release Notes
This does not affect to release notes. It's more mental thing.
How can this PR be tested?
Build branch with
debian/deb-autobake.shand then install packages nothing should be changed or check Salsa-CI runhttps://salsa.debian.org/illuusio/mariadb-server/-/pipelines/672483
which fails badly (which are be taken care of in other PR) but one can see that it works as expected.
Basing the PR against the correct MariaDB version
PR quality check