Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-34053 mariadbbackup privilege REPLICA MONITOR issue #3239

Conversation

grooverdan
Copy link
Member

  • The Jira issue number for this PR is: MDEV-34053

Description

MariaDB-backup needs to check for SLAVE MONITOR as that is what is returned by SHOW GRANTS.

Update test to ensure that warnings about missing privileges do not occur when the backup is successful.

Thanks Eugene for reporting the issue.

Release Notes

Remove erroneous MariaDB-Backup warnings about required privileges

How can this PR be tested?

TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".

If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

@grooverdan grooverdan added the MariaDB Foundation Pull requests created by MariaDB Foundation label May 3, 2024
@grooverdan grooverdan requested a review from LinuxJedi May 3, 2024 02:01
Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not happy that we need this fix at all. But, looks good to me :)

MariaDB-backup needs to check for SLAVE MONITOR as that is
what is returned by SHOW GRANTS.

Update test to ensure that warnings about missing privileges
do not occur when the backup is successful.

Reviewer: Andrew Hutchings
Thanks Eugene for reporting the issue.
@grooverdan grooverdan force-pushed the 10.5-MDEV-34053-mariabackup-replica-monitor branch from c9a33c7 to b2ad28b Compare May 8, 2024 23:05
@grooverdan grooverdan enabled auto-merge (rebase) May 8, 2024 23:06
@grooverdan grooverdan merged commit 034abab into MariaDB:10.5 May 8, 2024
15 of 17 checks passed
@grooverdan grooverdan deleted the 10.5-MDEV-34053-mariabackup-replica-monitor branch May 8, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MariaDB Foundation Pull requests created by MariaDB Foundation
2 participants