Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-33078 SysInfo.pm reports incorrect CPU count on macOS #3238

Merged
merged 2 commits into from May 6, 2024

Conversation

DaveGosselin-MariaDB
Copy link
Member

When running on macOS, MTR will ask the operating system for the core count when --parallel=auto

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ grooverdan
❌ DaveGosselin-MariaDB
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@grooverdan grooverdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I see no reason this couldn't be applied to 10.5, especially as you are probably going to be doing MacOS tests there for a while.

  1. rebase this pr
git rebase --onto origin/10.5 HEAD^
git push -f

(push should be to the same branch name, despite the version disparity).
2. edit PR title and change the destination branch to 10.5
3. enable automerge on the PR
4. it should automerge

When running on macOS, MTR will ask the operating system for the core count when --parallel=auto
@grooverdan grooverdan changed the base branch from 11.4 to 10.5 May 6, 2024 22:39
@grooverdan grooverdan enabled auto-merge (rebase) May 6, 2024 22:40
@grooverdan grooverdan merged commit 89084c2 into 10.5 May 6, 2024
14 of 19 checks passed
@grooverdan grooverdan deleted the 11.4-mdev-33078 branch May 6, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants