Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDEV-32619 Fix setting SRID with ST_*FromWKB() #3212

Open
wants to merge 1 commit into
base: 10.5
Choose a base branch
from

Conversation

MoonE
Copy link

@MoonE MoonE commented Apr 18, 2024

  • The Jira issue number for this PR is: MDEV-32619

Description

When using ST_GeomFromWKB(g, srid) where g is already a mysql geometry the srid argument was disregarded.

Release Notes

TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.

How can this PR be tested?

Test added to file gis.test

Basing the PR against the correct MariaDB version

  • This is a new feature and the PR is based against the latest MariaDB development branch.
  • This is a bug fix and the PR is based against the earliest maintained branch in which the bug can be reproduced.

PR quality check

  • I checked the CODING_STANDARDS.md file and my PR conforms to this where appropriate.
  • For any trivial modifications to the PR, I am ok with the reviewer making the changes themselves.

Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I would need to get someone who knows GIS better than me to review it too.

Please note that it won't land in 10.4, there is only one release left of that version which is reserved for critical / security fixes only. This will need to target 10.5 before it is merged. We should be able to do this our end though if this makes things easier for you.

@MoonE MoonE changed the base branch from 10.4 to 10.5 April 22, 2024 19:35
@CLAassistant
Copy link

CLAassistant commented Apr 22, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants