Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MDEV-33618: add mariadbd_safe to option groups #3130

Open
wants to merge 1 commit into
base: 11.5
Choose a base branch
from
Open

MDEV-33618: add mariadbd_safe to option groups #3130

wants to merge 1 commit into from

Conversation

andremralves
Copy link

@andremralves andremralves commented Mar 16, 2024 •
edited

  • The Jira issue number for this PR is: MDEV-33618

Description

  • Add mariadbd_safe to be used as an option group in my.cnf
  • Update man page.

@CLAassistant
Copy link

CLAassistant commented Mar 16, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@tonychen2001
Copy link

Also need to change references of mariadb_safe to mariadbd-safe in man/mysqld_safe.1

@andremralves
Copy link
Author

Also need to change references of mariadb_safe to mariadbd-safe in man/mysqld_safe.1

I wasn't sure if I should change the man pages because mariadb_safe still works, but I think it's better. Thanks.

@LinuxJedi
Copy link
Contributor

Also need to change references of mariadb_safe to mariadbd-safe in man/mysqld_safe.1

I wasn't sure if I should change the man pages because mariadb_safe still works, but I think it's better. Thanks.

Yes mariadb_safe works, but it is deprecated, so I think removing it from the man is safe. If you could add mariadbd-safe as well to what you have done, I think this is in a good place.

@grooverdan grooverdan added the need feedback Can the contributor please address the questions asked. label Apr 30, 2024
@andremralves
Copy link
Author

Yes mariadb_safe works, but it is deprecated, so I think removing it from the man is safe. If you could add mariadbd-safe as well to what you have done, I think this is in a good place.

Hi @LinuxJedi, thanks for the clarifications. I also added mariadbd-safe to the man page.

LinuxJedi
LinuxJedi approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@LinuxJedi LinuxJedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for fixing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinuxJedi LinuxJedi LinuxJedi approved these changes

@grooverdan grooverdan Awaiting requested review from grooverdan

Assignees

@LinuxJedi LinuxJedi

Labels
need feedback Can the contributor please address the questions asked.
Milestone
No milestone
5 participants
@andremralves @CLAassistant @tonychen2001 @LinuxJedi @grooverdan