MDEV-12404: Add assertions about Index Condition Pushdown use #3123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdered Fix Debian .install files to alphabetically ordered from mostly ordered state.
MariaDB debian control files are slightly in disorder run wrap-and-sort tool against them shows some minor changes.
During the build process this is wrapped into plugin_auth.h.
… to fail This was caused by the patch for MDEV-32567 Remove thr_alarm from server codebase
This was needed as mtr --embedded connect.alter failed as online is ignored for embedder server. This fixes a wrong commit 30c965f
allow RPM upgrades from a different minor version, if the major version is the same.
let ALL PRIVILEGES to always mean ALL PRIVILEGES over all upgrades, no matter what new privileges were added in later versions.
Support index condition pushdown within partitioned tables.
- ha_partition will pass the pushed index condition into all of the used
partitions.
- We require that all of the partitions to handle the pushed index
condition in the same way.
- When using ICP, one may read rows (e.g. call h->index_read_map(buf, ...)
only to buf= table->record[0], for two reasons:
* Pushed index condition's Item_field objects point into record[0]
* InnoDB requires this: it calls offset() which assumes record[0].
So, when using ICP, ha_partition will read partition records to
table->record[0] and then will copy record away if it needs it to be
elsewhere.
Add assertions about limitations one has when using Index Condition Pushdown: - add handler::assert_icp_limitations() - call this function from functions that may attempt violations. Verified that assert_icp_limitations() as well as calls to it are compiled away in release build.
spetrunia
force-pushed
the
bb-11.4-mdev12404-asserts
branch
from
4e54114
to
9f433c7
Compare
DaveGosselin-MariaDB
approved these changes
Mar 13, 2024
anson1014
reviewed
Apr 2, 2024
| pushed_idx_cond has Item_field objects that refer to table->record[0]. | ||
| */ | ||
| DBUG_ASSERT(!(pushed_idx_cond && active_index == pushed_idx_cond_keyno) || | ||
| (buf == table->record[0])); |
There was a problem hiding this comment.
nit: redundant parentheses
anson1014
reviewed
Apr 2, 2024
| void handler::assert_icp_limitations(uchar *buf) | ||
| { | ||
| /* | ||
| If we are using ICP, we must read the row to table->record[0], as |
There was a problem hiding this comment.
Good docs, explains the need for these assertions well
DaveGosselin-MariaDB
force-pushed
the
bb-11.4-mdev-12404
branch
from
4c55857
to
97a0665
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add assertions about limitations one has when using Index Condition Pushdown:
Verified that assert_icp_limitations() as well as calls to it are compiled away in release build.
Description
TODO: fill description here
Release Notes
TODO: What should the release notes say about this change?
Include any changed system variables, status variables or behaviour. Optionally list any https://mariadb.com/kb/ pages that need changing.
How can this PR be tested?
TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
PR quality check