MDEV:8146 - scripts/mysql_system_tables_fix.sql to use alter table add/drop if not exists/if exists #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR - can you rebase this on to the latest 11.4 ((assuming origin is MariaDB/server repo -> |
gulshanpr
force-pushed
the
MDEV-8146-scripts/mysql_system_tables_fix.sql-to-use-alter-table-add/drop-if-exists/if-not-exists
branch
3 times, most recently
from
42baf6f
to
9ec1a2e
Compare
gulshanpr
changed the title
|
@grooverdan Do I need to include test for this PR?, I think it is straight-forward. |
The existing code is executed in tests. No need to add anything. |
|
Check the error output in any of the failing tests above, there's a few syntax errors. Hopefully should be obvious from the error. I saw at least one that had the IF NOT EXITS before KEY. |
grooverdan
approved these changes
Feb 2, 2024
…/drop..if not exists Updated mariadb_system_tables_fix.sql to include checks using IF NOT EXISTS. Review: Daniel Black
grooverdan
force-pushed
the
MDEV-8146-scripts/mysql_system_tables_fix.sql-to-use-alter-table-add/drop-if-exists/if-not-exists
branch
from
7114905
to
94d1f0c
Compare
|
|
LinuxJedi
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added additional checks in scripts/mysql_system_tables_fix.sql to reduce error in log file, update includes IF EXISTS/IF NOT EXISTS for DROP/ADD statements
How can this PR be tested?
This PR updated ADD COLUMN to ADD COLUMN IF NOT EXISTS and same for DROP.
Basing the PR against the correct MariaDB version
PR quality check