mtr: macos test failures symlink + multiauth #3018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grooverdan
force-pushed
the
bb-10.4-macos-test-failures
branch
from
78623b0
to
08cf0d3
Compare
Needed to extend the buffer of replace_regex as with multiauth.test it shows all paths of not found resulting in 564 characters. ref: https://buildbot.mariadb.org/#/builders/590/builds/1903/steps/5/logs/stdio
grooverdan
force-pushed
the
bb-10.4-macos-test-failures
branch
from
08cf0d3
to
740eee5
Compare
| @@ -1,7 +1,7 @@ | |||
| create table t1 (a int) engine=myisam data directory='MYSQL_TMP_DIR'; | |||
| insert t1 values (1); | |||
| # Some systems fail with errcode 31 (FreeBSD), 40, or 90 (MIPS) when doing openat, | |||
| # while others don't have openat and fail with errcode 20. | |||
| # while others don't have openat and fail with errcode 20. MacOS has 62. | |||
There was a problem hiding this comment.
IMHO it might be clearer to say "MacOS fails with 62"
There was a problem hiding this comment.
Ack, Will correct. multiauth still failing, looks like the output line has exceeded the mysqltest length and the place I changed this isn't correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct test failures on MacOS.
How can this PR be tested?
https://buildbot.mariadb.org/#/grid?branch=refs/pull/3018/merge - on macos builder test output
Basing the PR against the correct MariaDB version
PR quality check