MDEV-18478 #2970
Open
MDEV-18478 #2970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Olernov
requested changes
Dec 30, 2023
…dex condition (Based on the original patch by Jason Cu) Part #1: - Add ha_handler_stats::{icp_attempts,icp_match}, make handler_index_cond_check() increment them. - ANALYZE FORMAT=JSON now prints r_icp_filtered based on these counters.
spetrunia
force-pushed
the
bb-11.4-MDEV-18478-v3
branch
from
2caf0ac
to
5658096
Compare
…dex condition Part#2: Make the printed r_ values in JSON output consistent. After this patch, ANALYZE output has: - r_index_rows (NEW) - Observed number of rows before ICP or Rowid Filtering checks. This is a per-scan average. like r_rows and "rows" are. - r_rows (AS BEFORE) - Observed number of rows after ICP and Rowid Filtering. - r_icp_filtered (NEW in MDEV-18478) - Observed selectivity of ICP condition. - (observed selectivity of Rowid Filter is in $.rowid_filter.r_selectivity_pct) - r_condition_filtered (NEW) - Observed selectivity of "attached_condition". This number was previously printed in r_filtered. - r_filtered - Observed combined selectivity: fraction of rows left after applying ICP condition, Rowid Filter, and attached_condition. This is now comparable with "filtered".
…rage, not total Make Explain_rowid_filter::print_explain_json() print "r_lookups" as per-loop average, not total. Per-loop average is comparable with parent JSON node's (that is, table's) "rows" and "r_rows", which are per-loop averages.
spetrunia
force-pushed
the
bb-11.4-MDEV-18478-v3
branch
from
b4d39e1
to
333d091
Compare
|
@Olernov , I believe I have addressed all of the review input. |
|
OK, thanks! No more comments from me. |
Olernov
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TODO: fill description here
How can this PR be tested?
TODO: modify the automated test suite to verify that the PR causes MariaDB to behave as intended.
Consult the documentation on "Writing good test cases".
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
PR quality check